Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 1 | #!/bin/bash |
| 2 | |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 3 | CHECKERHOME=$(pwd) |
| 4 | CHECKERLIB=$(dirname $(readlink -e $0)) |
| 5 | # auf Mac muss man ggf. $CHECKERLIB manuell zu dem Ordner setzen, in dem die |
| 6 | # Listen der zu testenden Funktionen liegen, wenn man noch irgendwie mit |
| 7 | # symlinks rumfummelt, weil Mac das nicht standardkompliant kann. ;-) |
| 8 | CODEFILES="${CHECKERHOME}/CODEFILES" |
| 9 | HEADERFILES="${CHECKERHOME}/HEADERFILES" |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 10 | #export LPCFILES="${HEADERFILES} ${CODEFILES}" |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 11 | LPCFILES="${CHECKERHOME}/LPCFILES" |
| 12 | MUDLIB="../mudlib" |
| 13 | LOGS="${CHECKERHOME}/logs" |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 14 | |
| 15 | LEVEL1="change_required" |
| 16 | LEVEL2="formatting" |
| 17 | LEVEL5="please_check" |
| 18 | LEVEL10="cosmetics" |
| 19 | |
| 20 | echo -ne "LPC-Source Checker V0.3 (2008-01-09)\n\n" |
| 21 | |
| 22 | usage() { |
| 23 | echo -ne "usage: ./check <region> <logfile>\n" |
| 24 | exit |
| 25 | } |
| 26 | |
| 27 | # Parameter pruefen, ansonsten usage ausgeben |
| 28 | if [ -z ${1} ] || [ -z ${2} ] |
| 29 | then |
| 30 | usage |
| 31 | fi |
| 32 | |
| 33 | # gucken ob das Logverzeichnis da ist, wenn nein, dann anlegen |
| 34 | if [ ! -d ${LOGS} ] |
| 35 | then |
| 36 | mkdir -p ${LOGS} |
| 37 | fi |
| 38 | |
| 39 | # rudimentaerer check ob die Mudlib da liegt, wo ${MUDLIB} hinzeigt |
| 40 | if [ ! -d ${MUDLIB} ] |
| 41 | then |
| 42 | echo -ne "No mudlib found in ${MUDLIB}\n" |
| 43 | exit |
| 44 | fi |
| 45 | |
| 46 | # alten Kram entsorgen |
| 47 | if [ -f ${CODEFILES} ] |
| 48 | then |
| 49 | rm ${CODEFILES} |
| 50 | fi |
| 51 | |
| 52 | if [ -f ${HEADERFILES} ] |
| 53 | then |
| 54 | rm ${HEADERFILES} |
| 55 | fi |
| 56 | |
| 57 | if [ -f ${LPCFILES} ] |
| 58 | then |
| 59 | rm ${LPCFILES} |
| 60 | fi |
| 61 | |
| 62 | echo -ne "Checking the MorgenGrauen Mudlib in ${MUDLIB}\n" |
| 63 | echo -ne "Checking in ${1} (${MUDLIB}${1})\n" |
| 64 | |
| 65 | cd ${MUDLIB} |
| 66 | |
| 67 | # Dateiliste erstellen |
| 68 | echo -ne "Creating file list...\n" |
| 69 | |
| 70 | find ./${1} -type f -name "*.c" -print > ${CODEFILES} |
| 71 | find ./${1} -type f -name "*.h" -print > ${HEADERFILES} |
| 72 | |
| 73 | # irgendwie unschoen |
| 74 | cat ${CODEFILES} ${HEADERFILES} > ${LPCFILES} |
| 75 | |
| 76 | # eigentlich haette man das alles in einem abfackeln koennen, aber dann gaebe |
| 77 | # es keine Ueberschriften ueber den einzelnen Punkten |
| 78 | |
| 79 | # LEVEL 1 CHECKS (change required) |
| 80 | |
| 81 | # Umlaute |
| 82 | echo -ne "\n\nPruefe auf Umlaute...\n" | tee -a ${LOGS}/${2}.${LEVEL1} |
| 83 | while read line |
| 84 | do |
| 85 | grep -Hn '[üöäÜÖÄß]' $line | cut -d : -f 1-2 >> ${LOGS}/${2}.${LEVEL1} |
| 86 | done < ${LPCFILES} |
| 87 | |
| 88 | # lambda() |
| 89 | echo -ne "\n\nPruefe auf lambda()...\n" | tee -a ${LOGS}/${2}.${LEVEL1} |
| 90 | while read line |
| 91 | do |
| 92 | grep -Hn 'lambda(' $line| cut -d : -f 1-2 >> ${LOGS}/${2}.${LEVEL1} |
| 93 | done < ${LPCFILES} |
| 94 | |
| 95 | # Pfade in /players/ |
| 96 | echo -ne "\n\nPruefe auf Pfade in /players/...\n" | tee -a ${LOGS}/${2}.${LEVEL1} |
| 97 | while read line |
| 98 | do |
| 99 | grep -Hn '/players/' $line| cut -d : -f 1-2 >> ${LOGS}/${2}.${LEVEL1} |
| 100 | done < ${LPCFILES} |
| 101 | |
| 102 | # fehlende #pragma strong_types/strict_types |
| 103 | echo -ne "\n\nFiles ohne #pragma strong_types oder strict_types...\n" | tee -a ${LOGS}/${2}.${LEVEL1} |
| 104 | while read line |
| 105 | do |
| 106 | grep -L '#pragma.\(strong\|strict\)_types' $line | sort \ |
| 107 | >> ${LOGS}/${2}.${LEVEL1} |
| 108 | done < ${CODEFILES} |
| 109 | |
| 110 | # direkte Verwendung von do_damage() |
| 111 | echo -ne "\n\nPruefe auf direkte Verwendung von do_damage()...\n" |\ |
| 112 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 113 | while read line |
| 114 | do |
| 115 | grep -Hn 'do_damage(' $line | cut -d : -f 1-2 >> ${LOGS}/${2}.${LEVEL1} |
| 116 | done < ${LPCFILES} |
| 117 | |
| 118 | # Unerwuenschte oder obsolete lfuns |
| 119 | echo -ne "\n\nPruefe auf unerwuenschte oder obsolete lfuns...\n" |\ |
| 120 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 121 | while read line |
| 122 | do |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 123 | grep -Hn -f ${CHECKERLIB}/bad_lfun.list $line >> ${LOGS}/${2}.${LEVEL1} |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 124 | done < ${LPCFILES} |
| 125 | |
| 126 | # Unerwuenschte oder obsolete efuns |
| 127 | echo -ne "\n\nPruefe auf unerwuenschte oder obsolete efuns...\n" |\ |
| 128 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 129 | while read line |
| 130 | do |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 131 | grep -Hn -f ${CHECKERLIB}/bad_efun.list $line >> ${LOGS}/${2}.${LEVEL1} |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 132 | done < ${LPCFILES} |
| 133 | |
| 134 | # Unerwuenschte oder obsolete Properties |
| 135 | echo -ne "\n\nPruefe auf unerwuenschte oder obsolete Properties...\n" |\ |
| 136 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 137 | while read line |
| 138 | do |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 139 | grep -Hn -f ${CHECKERLIB}/bad_prop.list $line >> ${LOGS}/${2}.${LEVEL1} |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 140 | done < ${LPCFILES} |
| 141 | |
| 142 | # Unerwuenschte Events |
| 143 | echo -ne "\n\nPruefe auf unerwuenschte Eventnamen...\n" | tee -a ${LOGS}/${2}.${LEVEL1} |
| 144 | while read line |
| 145 | do |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 146 | grep -Hn -f ${CHECKERLIB}/bad_events.list $line >> ${LOGS}/${2}.${LEVEL1} |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 147 | done < ${LPCFILES} |
| 148 | |
| 149 | # Keine clones von /std/thing |
| 150 | echo -ne "\n\nPruefe auf Clones von /std/thing...\n" |\ |
| 151 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 152 | while read line |
| 153 | do |
| 154 | grep -Hn 'clone_object(.*/std/thing.*)' $line | cut -d : -f 1-2 \ |
| 155 | >> ${LOGS}/${2}.${LEVEL1} |
| 156 | done < ${LPCFILES} |
| 157 | |
| 158 | # ueberschriebenes move() |
| 159 | echo -ne "\n\nPruefe auf ueberschriebenes move() (deprecated)...\n" |\ |
| 160 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 161 | while read line |
| 162 | do |
| 163 | grep -Hn 'int.*move(.*mixed.*int.*)' $line | cut -d : -f 1-2 \ |
| 164 | >> ${LOGS}/${2}.${LEVEL1} |
| 165 | done < ${LPCFILES} |
| 166 | |
| 167 | # wird geerbtes PreventMove gerufen? |
| 168 | echo -ne "\n\nUeberschriebenes PreventMove() ohne geerbetes zu rufen...\n" |\ |
| 169 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 170 | while read line |
| 171 | do |
Bugfix | 9225de2 | 2018-04-09 17:01:57 +0200 | [diff] [blame] | 172 | grep 'PreventMove(.*object.*object.*int.*)' $line > ${CHECKERHOME}/check.tmp |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 173 | grep -L '::PreventMove(' $line > ${CHECKERHOME}/check.tmp2 |
| 174 | done < ${LPCFILES} |
| 175 | # nur Zeilen ausgeben, die nicht im 2. File vorkommen |
| 176 | grep -v -f ${CHECKERHOME}/check.tmp2 ${CHECKERHOME}/check.tmp | \ |
| 177 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 178 | rm ${CHECKERHOME}/check.tmp* |
| 179 | |
Bugfix | ac979c4 | 2018-04-09 16:51:42 +0200 | [diff] [blame] | 180 | echo -ne "\n\nUeberschriebenes init() ohne geerbtes zu rufen...\n" |\ |
| 181 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 182 | while read line |
| 183 | do |
| 184 | grep 'init(\(object.*\)\?)' $line > ${CHECKERHOME}/check.tmp |
| 185 | grep -L '::init(' $line > ${CHECKERHOME}/check.tmp2 |
| 186 | done < ${LPCFILES} |
| 187 | grep -v -f ${CHECKERHOME}/check.tmp2 ${CHECKERHOME}/check.tmp \ |
| 188 | >> ${LOGS}/${2}.${LEVEL1} |
| 189 | rm ${CHECKERHOME}/check.tmp* |
| 190 | |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 191 | echo -ne "\n\nUeberschriebenes NotifyMove() ohne geerbetes zu rufen...\n" |\ |
| 192 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 193 | while read line |
| 194 | do |
Bugfix | 9225de2 | 2018-04-09 17:01:57 +0200 | [diff] [blame] | 195 | grep 'NotifyMove(.*object.*object.*int.*)' $line > ${CHECKERHOME}/check.tmp |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 196 | grep -L '::NotifyMove(' $line > ${CHECKERHOME}/check.tmp2 |
| 197 | done < ${LPCFILES} |
| 198 | grep -v -f ${CHECKERHOME}/check.tmp2 ${CHECKERHOME}/check.tmp \ |
| 199 | >> ${LOGS}/${2}.${LEVEL1} |
| 200 | rm ${CHECKERHOME}/check.tmp* |
| 201 | |
| 202 | # call_other(x, "???") ist obsolet |
| 203 | echo -ne "\n\nPruefe auf call_other(x, "???") (obsolet)...\n" |\ |
| 204 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 205 | while read line |
| 206 | do |
| 207 | grep -Hn 'call_other(.*???.*)' $line | cut -d : -f 1-2 \ |
| 208 | >> ${LOGS}/${2}.${LEVEL1} |
| 209 | done < ${LPCFILES} |
| 210 | |
| 211 | # Alte Syntax der Inline-Closures |
| 212 | echo -ne "\n\nPruefe auf obsolete Inline-Closures ( (: :) )...\n" | \ |
| 213 | tee -a ${LOGS}/${2}.${LEVEL1} |
| 214 | while read line |
| 215 | do |
| 216 | grep -Hn '(: ' $line | cut -d : -f 1-2 \ |
| 217 | >> ${LOGS}/${2}.${LEVEL1} |
| 218 | done < ${LPCFILES} |
| 219 | |
| 220 | # LEVEL 2 CHECKS |
| 221 | # Tabulatoren |
| 222 | echo -ne "\n\nPruefe auf Tabulatoren...\n" | tee -a ${LOGS}/${2}.${LEVEL2} |
| 223 | while read line |
| 224 | do |
| 225 | grep -Hn $'\t' $line | cut -d : -f 1-2 >> ${LOGS}/${2}.${LEVEL2} |
| 226 | done < ${LPCFILES} |
| 227 | |
| 228 | # Zeilen > 78 Zeichen |
| 229 | echo -ne "\n\nPruefe auf Zeilen > 78 Zeichen...\n" | tee -a ${LOGS}/${2}.${LEVEL2} |
| 230 | while read line |
| 231 | do |
| 232 | grep -Hn '.\{79,\}' $line| cut -d : -f 1-2 >> ${LOGS}/${2}.${LEVEL2} |
| 233 | done < ${LPCFILES} |
| 234 | |
| 235 | # LEVEL 5 CHECKS |
| 236 | # Header mit #pragmas |
| 237 | echo -ne "\n\nHeader (*.h) mit #pragmas...\n" | tee -a ${LOGS}/${2}.${LEVEL5} |
| 238 | while read line |
| 239 | do |
| 240 | grep -l '#pragma' $line >> ${LOGS}/${2}.${LEVEL5} |
| 241 | done < ${HEADERFILES} |
| 242 | |
| 243 | # efuns, Verwendung beachten |
| 244 | echo -ne "\n\nPruefe auf efuns, deren Verwendung beobachtet werden sollte...\n" |\ |
| 245 | tee -a ${LOGS}/${2}.${LEVEL5} |
| 246 | while read line |
| 247 | do |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 248 | grep -Hn -f ${CHECKERLIB}/warn_efun.list $line \ |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 249 | >> ${LOGS}/${2}.${LEVEL5} |
| 250 | done < ${LPCFILES} |
| 251 | |
| 252 | # Properties, Verwendung beachten |
| 253 | echo -ne "\n\nPruefe auf Properties, deren Verwendung beobachtet werden |
| 254 | sollte...\n" | tee -a ${LOGS}/${2}.${LEVEL5} |
| 255 | while read line |
| 256 | do |
Deaddy | 7583167 | 2018-12-28 11:23:24 +0100 | [diff] [blame^] | 257 | grep -EHn -f ${CHECKERLIB}/warn_prop.list $line \ |
Zesstra@Morgengrauen | 38e73d8 | 2016-02-02 22:24:24 +0100 | [diff] [blame] | 258 | >> ${LOGS}/${2}.${LEVEL5} |
| 259 | done < ${LPCFILES} |
| 260 | |
| 261 | # Pruefung auf static -> protected |
| 262 | echo -ne "\n\nPruefe auf 'static' (-> 'protected')...\n" |\ |
| 263 | tee -a ${LOGS}/${2}.${LEVEL5} |
| 264 | while read line |
| 265 | do |
| 266 | grep -Hn 'static' $line >> ${LOGS}/${2}.${LEVEL5} |
| 267 | done < ${LPCFILES} |
| 268 | |
| 269 | |
| 270 | # LEVEL 10 CHECKS |
| 271 | # Alte Rechtschreibung rules |
| 272 | echo -ne "\n\nKleingeschriebenes Du/Dir/Dich...\n" |\ |
| 273 | tee -a ${LOGS}/${2}.${LEVEL10} |
| 274 | while read line |
| 275 | do |
| 276 | grep -Hn ' \(du\|dich\|dir\) ' $line | cut -d : -f 1-2 | sort | \ |
| 277 | uniq >> ${LOGS}/${2}.${LEVEL10} |
| 278 | done < ${LPCFILES} |
| 279 | |
| 280 | # Pfadnamen bereinigen |
| 281 | sed -i -e 's#.//#/#g' ${LOGS}/${2}.* |
| 282 | |
| 283 | echo -ne "\nCheck finished!\n" |